This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Update colors to match guidance #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnmercier
approved these changes
Apr 20, 2018
| $mdc-text-field-error: #d50000; | ||
| $mdc-text-field-divider: rgba(black, .12); | ||
| $mdc-text-field-divider: rgba(mdc-theme-prop-value(on-surface), .12); |
There was a problem hiding this comment.
divider is a bad name, can you rename this?
| $mdc-text-field-label: rgba(black, .6); | ||
| $mdc-text-field-placeholder: rgba(black, .38); | ||
| $mdc-text-field-disabled-icon: rgba(mdc-theme-prop-value(on-surface), .3); | ||
| $mdc-text-field-underline-hover: rgba(mdc-theme-prop-value(on-surface), .87); |
There was a problem hiding this comment.
underline is also bad name, can you rename this?
Codecov Report
@@ Coverage Diff @@
## master #2597 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 98 98
Lines 4198 4198
Branches 533 533
=======================================
Hits 4143 4143
Misses 55 55Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update colors to match the latest guidance.
Removes the transparent background from the
--boxvariant by mixing the surface/on-surface colors with 4% opacity instead of just applying a 4% opacity on black.Adds new variables and remove inline usage of
-on-backgroundcolors, since those colors are wrong but not all components have new colors specified.