This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
style: Use single-line // comments in Sass
#2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi-line `/* ... */` comments get emitted verbatim in the CSS output, whereas single-line `//` comments do not. To test, run `npm run build` and compare `build/material-components-web.css` against the same file generated by `master`. You'll notice a bunch of seemingly random orphaned CSS comments are no longer emitted.
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 98 98
Lines 4198 4198
Branches 533 533
=======================================
Hits 4143 4143
Misses 55 55Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-line
/* ... */comments get emitted verbatim in the CSS output,whereas single-line
//comments do not.To test, run
npm run buildand comparebuild/material-components-web.cssagainst the same file generated bymaster.You'll notice a bunch of seemingly random orphaned CSS comments are no
longer emitted.