This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore(infrastructure): Report screenshot test results on GitHub PR #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 101 101
Lines 4368 4368
Branches 564 564
======================================
Hits 4294 4294
Misses 74 74 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Notes:
golden.json
file, so the tests will pass if the browsers render what the PR says they do. It's still up to the PR author and reviewer to diff againstorigin/master
'sgolden.json
and make sure the change makes sense.master
'sgolden.json
instead.How to test it
packages/
ortest/screenshot/
(such as this one).screenshot-test/butter-bot
status should appear - like magic.Example output
Pending - Running screenshot tests:
Passed - No diffs:
Failed - 4 Diffs found:
Full page: