This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: update default npm export to ES5 js files #3245
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
80eca3b
WIP: add main to package jsons
b55f5cc
fix: added main props to package.jsons for remaining components
6410afe
Update package.json
e43c556
Update package.json
21955dd
Merge branch 'master' into chore/infra/update-default-package-es5
cc1ee56
fix: unit test
39f9f31
fix: add main fields to packagejson
2e58cd5
Merge branch 'master' into chore/infra/update-default-package-es5
94fbfda
Merge branch 'master' into chore/infra/update-default-package-es5
3246ac5
Merge branch 'master' into chore/infra/update-default-package-es5
0570083
Merge branch 'master' into chore/infra/update-default-package-es5
48efeec
Merge remote-tracking branch 'origin/master' into chore/infra/update-…
20d06ae
WIP Update imports in new tests
62ced69
WIP Update scripts to verify main properties
399727b
WIP Fix broken package main properties
bd78014
WIP Add license to new script
853f2d5
WIP doc updates
ecacefc
WIP Add link to babel plugin
b1c6e83
WIP Update main README
5149579
Merge branch 'master' into chore/infra/update-default-package-es5
kfranqueiro 44dde56
WIP Remove empty files introduced during an earlier merge
7fcf8f1
Merge branch 'master' into chore/infra/update-default-package-es5
3cbdb21
Merge branch 'master' into chore/infra/update-default-package-es5
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This piece of info should also be in the getting-started.md
https://github.com/material-components/material-components-web/blame/master/docs/getting-started.md#L222
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had intended to look into the right place to add that to getting-started, thanks for reminding me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed that in #3665, since that PR was already touching the lines around that point in the file. That way hopefully it'll merge cleanly the next time we sync this PR.