Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(list): Follow hrefs on keypresses on links #3407

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Aug 23, 2018

Fixes #3406.

I also tested this by cherry-picking it into the feat/navigation-drawer branch, adding a unique hash to one of the drawer links, and testing click vs. space/enter, and both work (and also emit click events).

I also fixed formatting of a few test names and Sublime Text automatically removed some trailing whitespace (how'd all that get in there).

BREAKING CHANGE: Adds a followHref adapter API.

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit 57d0230 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 353 screenshot tests passed for commit eb17c32 vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e21eee3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3407   +/-   ##
=========================================
  Coverage          ?   98.41%           
=========================================
  Files             ?      123           
  Lines             ?     5183           
  Branches          ?      638           
=========================================
  Hits              ?     5101           
  Misses            ?       82           
  Partials          ?        0
Impacted Files Coverage Δ
packages/mdc-list/foundation.js 100% <100%> (ø)
packages/mdc-list/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21eee3...eb17c32. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kfranqueiro kfranqueiro merged commit e6d6deb into master Aug 24, 2018
@kfranqueiro kfranqueiro deleted the fix/list-follow-href branch August 24, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDC List: Support navigation for link list items on space/enter
5 participants