This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Follow hrefs on keypresses on links #3407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3406.
I also tested this by cherry-picking it into the feat/navigation-drawer branch, adding a unique hash to one of the drawer links, and testing click vs. space/enter, and both work (and also emit click events).
I also fixed formatting of a few test names and Sublime Text automatically removed some trailing whitespace (how'd all that get in there).
BREAKING CHANGE: Adds a followHref adapter API.