Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(menu): Allow anchor links as menu list items #3680

Merged
merged 4 commits into from
Oct 19, 2018
Merged

fix(menu): Allow anchor links as menu list items #3680

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b761e42
Allow anchor links as list items
jamesmfriedman Oct 1, 2018
32ab9c2
fix(menu): Add pointer events none to list item subelements for ancho…
williamernest Oct 18, 2018
08ca95d
Merge branch 'master' into patch-2
williamernest Oct 18, 2018
880a663
Merge branch 'master' into patch-2
williamernest Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mdc-menu/foundation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {cssClasses, strings} from './constants';
import {MDCMenuSurfaceFoundation} from '@material/menu-surface/foundation';
import MDCListFoundation from '@material/list/foundation';

const ELEMENTS_KEY_ALLOWED_IN = ['input', 'button', 'textarea', 'select'];
const ELEMENTS_KEY_ALLOWED_IN = ['input', 'button', 'textarea', 'select', 'a'];

/**
* @extends {MDCFoundation<!MDCMenuAdapter>}
Expand Down
7 changes: 7 additions & 0 deletions packages/mdc-menu/mdc-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@
.mdc-list-item--disabled {
cursor: auto;
}

//stylelint-disable selector-max-type, selector-no-qualifying-type
a.mdc-list-item .mdc-list-item__text,
a.mdc-list-item .mdc-list-item__graphic {
pointer-events: none;
}
// stylelint-enable selector-max-type, selector-no-qualifying-type
}

// postcss-bem-linter: define menu
Expand Down