Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(snackbar): Implement feedback from Design #4161

Merged
merged 8 commits into from
Dec 11, 2018

Conversation

acdvorak
Copy link
Contributor

Fixes #4156

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from feat/snackbar on commit 4a0ed2a:

Details

@acdvorak acdvorak removed the request for review from abhiomkar December 11, 2018 20:28
packages/mdc-snackbar/_mixins.scss Show resolved Hide resolved
packages/mdc-snackbar/README.md Outdated Show resolved Hide resolved
test/screenshot/golden.json Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from feat/snackbar on commit 40c51b8:

Details

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One readme nit, otherwise LGTM

packages/mdc-snackbar/README.md Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from feat/snackbar on commit ee7bdc9:

Details

@acdvorak acdvorak merged commit e790117 into feat/snackbar Dec 11, 2018
@acdvorak acdvorak deleted the feat/snackbar--feedback branch December 11, 2018 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants