This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(text-field): Added support for text field without label #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
suggested changes
Jan 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty reasonable, but I'd like us to run it by our designers for review before merging.
test/screenshot/spec/mdc-textfield/classes/focused-outlined-placeholder.html
Outdated
Show resolved
Hide resolved
kfranqueiro
reviewed
Jan 28, 2019
test/screenshot/spec/mdc-textfield/classes/focused-baseline-placeholder.html
Outdated
Show resolved
Hide resolved
test/screenshot/spec/mdc-textfield/classes/focused-outlined-placeholder.html
Outdated
Show resolved
Hide resolved
kfranqueiro
reviewed
Jan 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golden.json also needs updating.
🤖 Beep boop! Screenshot test report 🚦19 screenshots changed from Details |
Updated golden screenshots. |
kfranqueiro
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once goldens are updated for the last changes
🤖 Beep boop! Screenshot test report 🚦15 screenshots changed from |
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features included:
Fixes #4239
Screenshot: