This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Update default notifyAction impl to emit object #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4355 BREAKING CHANGE: The default `MDCListAdapter.notifyAction()` implementation now emits an object of type `{index: number}` rather than a primitive `number` directly.
Codecov Report
@@ Coverage Diff @@
## master #4356 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 130 130
Lines 5731 5731
Branches 763 763
=======================================
Hits 5649 5649
Misses 82 82
Continue to review full report at Codecov.
|
|
All 621 screenshot tests passed for commit d99a2b3 vs. |
kfranqueiro
reviewed
Feb 5, 2019
|
All 621 screenshot tests passed for commit 9dea6a5 vs. |
…nents/material-components-web into fix/list/notifyAction-api
kfranqueiro
suggested changes
Feb 5, 2019
|
All 621 screenshot tests passed for commit 9a29392 vs. |
|
Updated unit test to |
kfranqueiro
approved these changes
Feb 5, 2019
|
All 621 screenshot tests passed for commit 6152bf8 vs. |
acdvorak
added a commit
that referenced
this pull request
Feb 7, 2019
This fixes a regression caused by PR #4356, and adds a unit test to catch future integration failures between list and menu events.
acdvorak
added a commit
that referenced
this pull request
Feb 7, 2019
This fixes a regression caused by PR #4356, and adds a unit test to catch future integration failures between list and menu events.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4355
BREAKING CHANGE: The default
MDCListAdapter.notifyAction()implementation now emits an object of type{index: number}rather than a primitivenumberdirectly.