This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(list): Update interactive list's with ripple-upgrade to be narrower #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #463, Update interactive list's with ripple-upgrade to be narrower. Padding of list items is 16 + 16 = 32px, so width of list items should be container's width - 32px.
traviskaufman
approved these changes
Apr 3, 2017
There was a problem hiding this comment.
💎 💯 Thank you @lynnjepsen! As soon as CI goes green feel free to Squash and Merge
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 2037 2037
Branches 260 260
=======================================
Hits 2020 2020
Misses 17 17Continue to review full report at Codecov.
|
pgbross
pushed a commit
to pgbross/material-components-web
that referenced
this pull request
Apr 5, 2017
…er (material-components#468) Resolves material-components#463, Update interactive list's with ripple-upgrade to be narrower. Padding of list items is 16 + 16 = 32px, so width of list items should be container's width - 32px.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #463, Update interactive list's with ripple-upgrade to be narrower. Padding of list items is 16 + 16 = 32px, so width of list items should be container's width - 32px.