This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(checkbox): screenshot test golden update #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep boop! Screenshot test report 🚦1 screenshot changed from Details1 Changed: |
|
This test was flaky for me earlier. Do you want to remove autofocus? |
|
Or let’s move autofocus to unchecked checkbox. |
|
@abhiomkar how will moving autofocus fix the issue? |
|
@moog16 Seems like the ripple z position is flaky with the check mark icon. We can avoid this flaky test by moving the focus to unchecked checkbox. |
|
🤖 Beep boop! Screenshot test report 🚦3 screenshots changed from Details3 Changed: |
abhiomkar
approved these changes
May 21, 2019
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing checkbox screenshot test. SVG has changed on Firefox.