Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(chips): Add setAttr adapter method #4736

Merged
merged 5 commits into from
May 20, 2019
Merged

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented May 17, 2019

Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles.

BREAKING CHANGE: Add the setAttr method to the chip adapter.

@mdc-web-bot
Copy link
Collaborator

All 693 screenshot tests passed for commit 14c3d63 vs. develop! 💯🎉

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #4736 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4736      +/-   ##
===========================================
- Coverage    98.96%   98.95%   -0.02%     
===========================================
  Files          129      129              
  Lines         6285     6289       +4     
  Branches       820      820              
===========================================
+ Hits          6220     6223       +3     
- Misses          64       65       +1     
  Partials         1        1
Impacted Files Coverage Δ
packages/mdc-chips/chip/component.ts 97.43% <0%> (-1.27%) ⬇️
packages/mdc-chips/chip/foundation.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9172d0...8110d0f. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

@patrickrodee patrickrodee merged commit ce365e0 into develop May 20, 2019
@patrickrodee patrickrodee deleted the chipsattributesetting branch May 20, 2019 19:37
moog16 pushed a commit that referenced this pull request May 28, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles.

BREAKING CHANGE: Add the setAttr method to the chip adapter.
moog16 pushed a commit that referenced this pull request Jun 3, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles.

BREAKING CHANGE: Add the setAttr method to the chip adapter.
abhiomkar pushed a commit that referenced this pull request Jun 11, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles.

BREAKING CHANGE: Add the setAttr method to the chip adapter.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants