This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(chips): Add setAttr adapter method #4736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All 693 screenshot tests passed for commit 14c3d63 vs. |
Codecov Report
@@ Coverage Diff @@
## develop #4736 +/- ##
===========================================
- Coverage 98.96% 98.95% -0.02%
===========================================
Files 129 129
Lines 6285 6289 +4
Branches 820 820
===========================================
+ Hits 6220 6223 +3
- Misses 64 65 +1
Partials 1 1
Continue to review full report at Codecov.
|
abhiomkar
approved these changes
May 20, 2019
🤖 Beep boop! Screenshot test report 🚦1 screenshot changed from Details |
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles. BREAKING CHANGE: Add the setAttr method to the chip adapter.
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles. BREAKING CHANGE: Add the setAttr method to the chip adapter.
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Add MDCChipAdapter#setAttr method. Update screenshot tests with appropriate roles. BREAKING CHANGE: Add the setAttr method to the chip adapter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MDCChipAdapter#setAttr
method. Update screenshot tests with appropriate roles.BREAKING CHANGE: Add the
setAttr
method to the chip adapter.