This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(dialog): Fix scrolling content overflowing on Chrome/Android. #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4746 +/- ##
=========================================
Coverage ? 98.96%
=========================================
Files ? 129
Lines ? 6285
Branches ? 820
=========================================
Hits ? 6220
Misses ? 64
Partials ? 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #4746 +/- ##
===========================================
+ Coverage 98.95% 98.95% +<.01%
===========================================
Files 129 129
Lines 6289 6326 +37
Branches 820 820
===========================================
+ Hits 6223 6260 +37
Misses 65 65
Partials 1 1
Continue to review full report at Codecov.
|
abhiomkar
approved these changes
May 23, 2019
|
🤖 Beep boop! Screenshot test report 🚦16 screenshots changed from |
joyzhong
changed the title
joyzhong
added a commit
that referenced
this pull request
May 28, 2019
Use 100vw as it doesn't have the same browser incompatibilities that 100vh does (see PR #4746 for context). 100% width on the other hand breaks on mobile/Safari.
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
moog16
pushed a commit
that referenced
this pull request
May 28, 2019
Use 100vw as it doesn't have the same browser incompatibilities that 100vh does (see PR #4746 for context). 100% width on the other hand breaks on mobile/Safari.
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
moog16
pushed a commit
that referenced
this pull request
Jun 3, 2019
Use 100vw as it doesn't have the same browser incompatibilities that 100vh does (see PR #4746 for context). 100% width on the other hand breaks on mobile/Safari.
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
Use 100vw as it doesn't have the same browser incompatibilities that 100vh does (see PR #4746 for context). 100% width on the other hand breaks on mobile/Safari.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vhincludes the browser top/bottom bars on Chrome/Android and is inconsistent in Safari, causing scrolling content to overflow.