Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(infrastructure): Print the entire invalid git commit message. #510

Merged
merged 1 commit into from
Apr 13, 2017
Merged

fix(infrastructure): Print the entire invalid git commit message. #510

merged 1 commit into from
Apr 13, 2017

Conversation

shyndman
Copy link
Contributor

Previously only the invalidate subject line would print, so if you'd written a big meaty comment that failed to validate you'd have to rewrite it.

Previously only the invalidate subject line would print, so if you'd written a big meaty comment that failed to validate you'd have to rewrite it.
@shyndman
Copy link
Contributor Author

This happened to me. 😠

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

Merging #510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          45       45           
  Lines        2050     2050           
  Branches      251      251           
=======================================
  Hits         2030     2030           
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a2352...43e0394. Read the comment docs.

Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Skipping CI since it looks like failures were (obvious) false negatives.

Btw you can put in commit message bodies [ci skip] on changes that don't touch any code to have TravisCI skip it :)

@traviskaufman traviskaufman merged commit ea8f862 into material-components:master Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants