This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(infrastructure): correct reason why component is shown in summary table. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 49 49
Lines 2051 2051
Branches 251 251
=======================================
Hits 2031 2031
Misses 20 20Continue to review full report at Codecov.
|
yeelan0319
force-pushed
the
fix/correct-commit-msg-show-in-summarize-table
branch
from
1f886dc to
f107cae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The reason for version bumping shown in
pre-release.shhave the following case which it cannot handle properly.When package version for a component is bumped for its dependency being updated, however, it happens to have one and only one commit msg for
docs(some-component): xxxx. In the summary table, it will show the reason for this version bump is cased by the documentation update. However, the actual reason this package is selected is because lerna correctly detects its dependency update.This used to cause some confusion when we release
0.7.0.