Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce the layout function in the list component #1951

Merged
merged 16 commits into from
Nov 17, 2020

Conversation

copybara-service[bot]
Copy link

Debounce the layout function in the list component

when removing an item.

Closes #1927

See my remarks blow regarding the outcome of this performance improvement, and proposed changes to this PR.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#1928 from YonatanKra:fix-list-performance-issue d47cf23

@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@copybara-service copybara-service bot force-pushed the cl/341937184 branch 4 times, most recently from d4f8d2c to 98f1ccc Compare November 17, 2020 19:12
@copybara-service copybara-service bot merged commit 03e7e77 into master Nov 17, 2020
@copybara-service copybara-service bot deleted the cl/341937184 branch November 17, 2020 19:22
@google-cla
Copy link

google-cla bot commented Nov 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When list items are removed list.layout is called multiple times can causes a performance issue
2 participants