Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): 🔖 add appropriate labels to PRs with failed checks #2785

Merged
merged 9 commits into from
Jan 6, 2025

Conversation

okineadev
Copy link
Member

@okineadev okineadev commented Jan 6, 2025

Add steps to workflows to manage labels based on workflow results.

This will provide a convenient understanding of the problem with PR

  • Color Check Workflow:

    • Add permission to write pull requests.
    • Add step to manage invalid-colors label based on color check result.
  • Build Workflow:

    • Add permission to write pull requests.
    • Add step to manage invalid-build label based on build result.
  • PR Title Workflow:

    • Add step to manage invalid-title label based on PR title check result.

For more details, open the Copilot Workspace session.

Add steps to workflows to manage labels based on workflow results.

* **Color Check Workflow**:
  - Add permission to write pull requests.
  - Add step to manage `invalid-colors` label based on color check result.

* **Build Workflow**:
  - Add permission to write pull requests.
  - Add step to manage `invalid-build` label based on build result.

* **PR Title Workflow**:
  - Add step to manage `invalid-title` label based on PR title check result.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/material-extensions/vscode-material-icon-theme?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions github-actions bot added the 🔄 workflows GitHub Actions label Jan 6, 2025
@okineadev okineadev requested a review from Copilot January 6, 2025 07:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@okineadev okineadev added 🔄 workflows and removed 🔄 workflows GitHub Actions labels Jan 6, 2025
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it would be worth checking if we can make use of reusable workflows:

https://docs.github.com/en/actions/sharing-automations/reusing-workflows

.github/workflows/color-check.yml Outdated Show resolved Hide resolved
.github/workflows/pr-title.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
okineadev and others added 2 commits January 6, 2025 12:14
Co-authored-by: Philipp Kief <[email protected]>
Signed-off-by: Okinea Dev <[email protected]>
Co-authored-by: Philipp Kief <[email protected]>
Signed-off-by: Okinea Dev <[email protected]>
@github-actions github-actions bot added the 🔄 workflows GitHub Actions label Jan 6, 2025
Co-authored-by: Philipp Kief <[email protected]>
Signed-off-by: Okinea Dev <[email protected]>
PKief
PKief previously approved these changes Jan 6, 2025
@PKief
Copy link
Member

PKief commented Jan 6, 2025

@okineadev btw, the label has been added again :D

image

@okineadev
Copy link
Member Author

dont merge

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/actions/update-status-label.sh: Language not supported
@okineadev okineadev requested a review from Copilot January 6, 2025 12:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/actions/update-status-label.sh: Language not supported
@okineadev

This comment was marked as off-topic.

@okineadev
Copy link
Member Author

After you merge this PR, I will create a new PR with the updated label format with emoji (<emoji> <title>)

@PKief PKief merged commit 26b4377 into main Jan 6, 2025
1 check passed
@PKief PKief deleted the okineadev/add-labels-to-workflows branch January 6, 2025 15:36
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

PKief added a commit to rowan-walsh/vscode-material-icon-theme that referenced this pull request Jan 6, 2025
PKief added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔄 workflows GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants