Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: build step failled #88

Closed
roiLeo opened this issue Mar 23, 2021 · 0 comments
Closed

bug: build step failled #88

roiLeo opened this issue Mar 23, 2021 · 0 comments
Labels
bug Something isn't working build documentation Improvements or additions to documentation

Comments

@roiLeo
Copy link
Member

roiLeo commented Mar 23, 2021

Expected Behavior

No errors in pull requests

Current Behavior

Github actions trigger error on step "Deploy to Github Pages" because {{secrets.GITHUB_TOKEN}} is not shareable.

Possible Solution

Deploy documentation on push master.
Possible solution is to create a new 'deploy' step with :
if: github.ref == 'refs/heads/master'
@roiLeo roiLeo added bug Something isn't working build documentation Improvements or additions to documentation labels Mar 23, 2021
ChildishGiant added a commit to ChildishGiant/materialize that referenced this issue Mar 23, 2021
@ChildishGiant
fix: 🔨 fix materializecss#88
ff79f22
ChildishGiant added a commit to ChildishGiant/materialize that referenced this issue Mar 23, 2021
@ChildishGiant
fix: 🔨 fix materializecss#88
0fb2f9f
Smankusors added a commit that referenced this issue Mar 24, 2021
@Smankusors
Merge pull request #89 from ChildishGiant/v1-dev
bab072a 
fix: 🔨 fix #88
@ChildishGiant ChildishGiant mentioned this issue Mar 24, 2021
Merged
8 tasks
bugy pushed a commit to bugy/materialize that referenced this issue Oct 3, 2021
@ChildishGiant @bugy
fix: 🔨 fix materializecss#88
bf4d6be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roiLeo