Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Feature Discovery #112

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix issue with Feature Discovery #112

merged 1 commit into from
Apr 27, 2021

Conversation

warrenrodrigues
Copy link

@warrenrodrigues warrenrodrigues commented Apr 25, 2021 •
edited by ChildishGiant
Loading

Proposed changes

Fix issue #97 Feature discovery moves element when activated by @ChildishGiant

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Smankusors Smankusors added bugfix css/sass For something that related to styling/view labels Apr 26, 2021
@DanielRuf DanielRuf requested a review from a team April 26, 2021 21:56
@ChildishGiant
Copy link
Member

Looks all good on my end!

XQvuyQC8eN.mp4

@DanielRuf DanielRuf merged commit b5b464c into materializecss:v1-dev Apr 27, 2021
@DanielRuf
Copy link

Hi @warrenrodrigues,

many thanks for your contribution.
I have sent you an invitation to the @materializecss org and the members group.

@warrenrodrigues
Copy link
Author

Thanks @DanielRuf
Accepted.

Thank you for keeping this project alive.

@Smankusors Smankusors added the bug Something isn't working label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChildishGiant ChildishGiant ChildishGiant approved these changes

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working css/sass For something that related to styling/view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@warrenrodrigues @ChildishGiant @DanielRuf @Smankusors