Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rework about and home page to mention this is the community fork #217

Merged
merged 2 commits into from
Oct 29, 2021
Merged

docs: rework about and home page to mention this is the community fork #217

merged 2 commits into from
Oct 29, 2021

Conversation

LoganTann
Copy link

Proposed changes

  • Added the community as part of the team, by explaining why we forked the repo and by adding a
    dynamic image that show the top 24 contributors. Prob is that it don't sort by team members but
    rather by commit numbers
  • Added a message in the index page that says this version is a fork
  • Changed the catchphrase in the homepage
  • Rephrased a sentence inside the introduction grid shown in the homepage and grid section

fix #194

Screenshots (if appropriate) or codepen:

Click here to see screenshots & changes:

image
image

Types of changes

  • Docs

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • (not needed) I have added tests to cover my changes.
  • All new and existing tests passed.

…sion, and minor changes

- Added the community as part of the team, by explaining why we forked the repo and by adding a
dynamic image that show the top 24 contributors. Prob is that it don't sort by team members but
rather by commit numbers - Added a message in the index page that says this version is a fork -
Changeed the catchphrase in the homepage - Rephrased a sentence inside the introduction grid shown
in the homepage and grid section

fix #194
@LoganTann
Copy link
Author

I took more than 1h30 to write that. It's very difficult to phrase things well in order to stay the less subjective possible, so I hope everything is fine.

Anyway, feel free to leave reviews.

@LoganTann LoganTann requested a review from a team October 28, 2021 13:14
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am Not listed in the members :(

@DanielRuf
Copy link

@wuda-io the URL lists / shows only the top 24 contributors (commits) who contributed commits to the main branch.

https://contrib.rocks/image?repo=materializecss/materialize&max=50 shows the top 50 contributors.

See also https://github.com/materializecss/materialize/graphs/contributors

@wuda-io
Copy link
Member

wuda-io commented Oct 28, 2021

@wuda-io the URL lists / shows only the top 24 contributors (commits) who contributed commits to the main branch.

https://contrib.rocks/image?repo=materializecss/materialize&max=50 shows the top 50 contributors.

See also https://github.com/materializecss/materialize/graphs/contributors

Yes I have to make more commits 😜

@LoganTann
Copy link
Author

Thanks for the reviews I will correct this tonight

@LoganTann
Copy link
Author

ready to be merged @materializecss/members-write-access

@DanielRuf DanielRuf merged commit b529448 into materializecss:main Oct 29, 2021
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework About page and copy throughout docs
5 participants