-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change tooltip animate opacity. #23
Conversation
FYI, that update to the _footer.html file was due to the fact that I initially forked Dogfalo/materialize first... that's where the change came from. To eliminate the file from this PR I just removed the change. |
hmm IMO, I don't see why there's any use case to change the animate opacity? It's kinda hard to read if the opacity below 0.5... also why the added option begin with underscore? |
And the opacity above 0.5? As you can see in the gif, opacity is set at 0.7. Without this change the tooltip simply gets stuck as overriding the opacity in css breaks the element hiding. The underscore was based on the function name the setting is found in tooltip.js.
|
even though 0.7, for me it's hard to read 😵
I mean... you can see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the underscore.
More options are always a good idea.
But keep in mind that by default materialize strictly follows Material Design spec by Google.
Definitely. |
Renamed the option per feedback. Also updated doc. |
Shouldn't this be handled by custom CSS rules instead of a feature right in Materialize? 🤔 |
|
Proposed changes
Currently using this library for NiM and would like to keep transparent tooltips as seen here:
![NiM Transparent Tooltips](https://user-images.githubusercontent.com/11353590/93024244-d16bc300-f5a9-11ea-916d-08ebe6c23f2a.gif)
This small change adds the ability to change tooltip default opacity using options. The ultimate result are tooltips that can be transparent.
Types of changes
Checklist: