-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs : added a searchable link #225 #238
Conversation
Hi @DanielRuf , Thanks. |
@MadhaviMandalia commitlint reports this:
It should look like this:
We use the conventional config: You can see some examples at https://www.conventionalcommits.org/en/v1.0.0/ |
@MadhaviMandalia all good with the commit 👍 But you have to create a separate / new branch (please don't use the ?main` branch otherwise this could lead to conflicts), from the current version of our main branch. I guess you need these commands: git checkout -b main-temp # create copy of current branch
git branch -D main # delete old main branch
git remote add upstream [email protected]:materializecss/materialize.git # add upstream repo
git checkout main # checkout main of your fork
git merge upstream/main # update your main branch with the upstream one
git checkout -b fix/225-link-icon-list
git add ... & git commit -m '...'
git push -u origin fix/225-link-icon-list
# create new PR Alternatively recreate your fork, create a new branch from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use this link instead?
See #225 (comment) |
Proposed changes
Types of changes
Checklist: