Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gruntfile.js to prevent erroneous replace #28

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

nekonenene
Copy link

@nekonenene nekonenene commented Sep 19, 2020

Proposed changes

When exec the release script npx grunt release --oldver=1.0.0 --newver=1.0.1, grunt accidentally replaced "grunt-contrib-jade": "^1.0.0" to "grunt-contrib-jade": "^1.0.1". This behavior can cause a problem, so I fixed it to replace the strings appropriately. Additionally, I removed replace:readme task because the description of "Current Version : " has already disappeared from README.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing this.

@DanielRuf DanielRuf requested review from a team September 20, 2020 22:58
Copy link

@Pierstoval Pierstoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with this!

I'm wondering whether we could move the project forward by changing the build process for a "simpler/modern/easier to maintain" one 🤔

@DanielRuf DanielRuf merged commit ca5c2f0 into materializecss:v1-dev Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants