Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon tabs #370

Closed
wants to merge 2 commits into from
Closed

Icon tabs #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78c6528
feat: tabs with icons example
danice May 7, 2023
c7a85be
fix: tab was not selected when clicked in the icon
danice May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions pug/contents/tabs_content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,30 @@ <h3 class="header">Fixed Width Tabs</h3>
&lt;div id="test0" class="col s12">&lt;p>Test 5&lt;/p>&lt;/div>
</code></pre>
</div>

<div id="icon-tabs" class="scrollspy section">
<h3 class="header">Icons</h3>
<ul class="tabs tabs-fixed-width tab-demo z-depth-1">
<li class="tab"><a href="#image-test1"><i class="material-icons">flight</i></a></li>
<li class="tab"><a class="active" href="#image-test2"><i class="material-icons">luggage</i></a></li>
<li class="tab"><a href="#image-test3"><i class="material-icons">explore</i></a></li>
</ul>
<div id="image-test1" class="col s12"><p>Test 1</p></div>
<div id="image-test2" class="col s12"><p>Test 2</p></div>
<div id="image-test3" class="col s12"><p>Test 3</p></div>

<pre><code class="language-markup">
&lt;ul class="tabs tabs-fixed-width tab-demo z-depth-1">
&lt;li class="tab">&lt;a href="#image-test1">&lt;i class="material-icons">flight&lt;/i>&lt;/a>&lt;/li>
&lt;li class="tab">&lt;a class="active" href="#image-test2">&lt;i class="material-icons">luggage&lt;/i>&lt;/a>&lt;/li>
&lt;li class="tab">&lt;a href="#image-test3">&lt;i class="material-icons">explore&lt;/i>&lt;/a>&lt;/li>
&lt;/ul>
&lt;div id="image-test1" class="col s12">&lt;p>Test 1&lt;/p>&lt;/div>
&lt;div id="image-test2" class="col s12">&lt;p>Test 2&lt;/p>&lt;/div>
&lt;div id="image-test3" class="col s12">&lt;p>Test 3&lt;/p>&lt;/div>
</code></pre>
</div>

</div>

<!-- Table of Contents -->
Expand All @@ -275,6 +299,7 @@ <h3 class="header">Fixed Width Tabs</h3>
<li><a href="#external">External Links</a></li>
<li><a href="#swipeable">Swipeable Tabs</a></li>
<li><a href="#fixed-width">Fixed Width Tabs</a></li>
<li><a href="#icon-tabs">Icons</a></li>
</ul>
</div>
</div>
Expand Down
12 changes: 10 additions & 2 deletions src/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,16 @@ export class Tabs extends Component {
}

_handleTabClick(e) {
const tabLink = e.target;
const tab = tabLink.parentElement;
var tabLink = e.target;
if (!tabLink)
return;
var tab = tabLink.parentElement;
while (tab && !tab.classList.contains('tab')) {
tabLink = tabLink.parentElement;
tab = tab.parentElement;
}
if (!tab)
return;
// Handle click on tab link only
if (!tabLink || !tab.classList.contains('tab')) return;
// is disabled?
Expand Down