Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid overwritting of base property 'el' in 'Component' #388

Closed
wants to merge 1 commit into from

Conversation

danice
Copy link

@danice danice commented Jun 19, 2023

Proposed changes

Avoid the typescript error
TS2612: Property 'el' will overwrite the base property in 'Component'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

Types of changes

Adding 'declare' property modificator.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danice
Copy link
Author

danice commented Jun 19, 2023

Proposal: Maybe it could be better to change el: Element property of Component to el: HTMLElement and just remove the redeclared property, except for the cases where it changed the type, for example to HTMLInputElemen.

@mauromascarenhas
Copy link

mauromascarenhas commented Jun 19, 2023

Proposal: Maybe it could be better to change el: Element property of Component to el: HTMLElement and just remove the redeclared property, except for the cases where it changed the type, for example to HTMLInputElemen.

This is actually a basic concept of inheritance. It'd be great to have it updated 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants