Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(Utils) implemented confirmation container util methods #574

Merged

Conversation

gselderslaghs
Copy link
Member

Proposed changes

This is a proof-of-concept for #570
Implemented confirmation container util with callback functions so it's reusable among other components

Example of creating a single button with callback method:

Utils.createButton(
  '.container', // container to append to
  'Label', // button label 
  ['teal', 'btn-large'], // additional classes
  true, // visibility
  callback // callback method
);

Example of creating a confirmation container:

Utils.createConfirmationContainer(
  '.container', // container to append to
  'Confirm', // button label
  'Cancel', // button label
  confirm, // confirm callback
  cancel // cancel callback
);

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM.

@wuda-io wuda-io merged commit 4805660 into materializecss:v2-dev Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants