-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added more fields to electrode doc #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munrojm
pushed a commit
that referenced
this pull request
Mar 24, 2021
…pymatgen objects (#223) * Bump required monty version * Change how pydantic objects are reconstructed in the client * Add comment * Start switch to using native pymatgen models * Update tasks endpoint to use pymatgen models * Pymatgen version import fix * task_id list search added to tasks * Insertion electrode model and query op updates * Multiple task_id search added to molecules * Deprecation query changed to list of task_ids * Linting * client: catch __version__ import for old pymatgen * dependabot PRs Bump boto3 from 1.17.22 to 1.17.32 Bumps [boto3](https://github.com/boto/boto3) from 1.17.22 to 1.17.32. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.22...1.17.32) Signed-off-by: dependabot[bot] <[email protected]> Bump flake8 from 3.8.4 to 3.9.0 Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.4 to 3.9.0. - [Release notes](https://gitlab.com/pycqa/flake8/tags) - [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.4...3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Bump pre-commit from 2.11.0 to 2.11.1 Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 2.11.0 to 2.11.1. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v2.11.0...v2.11.1) Signed-off-by: dependabot[bot] <[email protected]> Bump pycodestyle from 2.6.0 to 2.7.0 Bumps [pycodestyle](https://github.com/PyCQA/pycodestyle) from 2.6.0 to 2.7.0. - [Release notes](https://github.com/PyCQA/pycodestyle/releases) - [Changelog](https://github.com/PyCQA/pycodestyle/blob/master/CHANGES.txt) - [Commits](https://github.com/PyCQA/pycodestyle/commits) Signed-off-by: dependabot[bot] <[email protected]> * Bump boto3 from 1.17.32 to 1.17.33 Bumps [boto3](https://github.com/boto/boto3) from 1.17.32 to 1.17.33. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.32...1.17.33) Signed-off-by: dependabot[bot] <[email protected]> * Wildcard added to chemsys search * InsertionElectrode object added to model * API pinned to temp monty fix * Linting * github testing updated from master to main * Mypy fixes * Ignore missing imports mypy * Literal pulled from typing_extensions * More linting * added more fields to electrode doc (#229) * added more fields to electrode doc * added elements field * linting * update * more useful fields Co-authored-by: Jason Munro <[email protected]> Co-authored-by: Patrick Huck <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JSX <[email protected]>
munrojm
pushed a commit
that referenced
this pull request
Mar 26, 2021
…p upgrades (#233) * Bump required monty version * Change how pydantic objects are reconstructed in the client * Add comment * Start switch to using native pymatgen models * Update tasks endpoint to use pymatgen models * Pymatgen version import fix * task_id list search added to tasks * Insertion electrode model and query op updates * Multiple task_id search added to molecules * Deprecation query changed to list of task_ids * Linting * client: catch __version__ import for old pymatgen * dependabot PRs Bump boto3 from 1.17.22 to 1.17.32 Bumps [boto3](https://github.com/boto/boto3) from 1.17.22 to 1.17.32. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.22...1.17.32) Signed-off-by: dependabot[bot] <[email protected]> Bump flake8 from 3.8.4 to 3.9.0 Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.4 to 3.9.0. - [Release notes](https://gitlab.com/pycqa/flake8/tags) - [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.4...3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Bump pre-commit from 2.11.0 to 2.11.1 Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 2.11.0 to 2.11.1. - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v2.11.0...v2.11.1) Signed-off-by: dependabot[bot] <[email protected]> Bump pycodestyle from 2.6.0 to 2.7.0 Bumps [pycodestyle](https://github.com/PyCQA/pycodestyle) from 2.6.0 to 2.7.0. - [Release notes](https://github.com/PyCQA/pycodestyle/releases) - [Changelog](https://github.com/PyCQA/pycodestyle/blob/master/CHANGES.txt) - [Commits](https://github.com/PyCQA/pycodestyle/commits) Signed-off-by: dependabot[bot] <[email protected]> * Bump boto3 from 1.17.32 to 1.17.33 Bumps [boto3](https://github.com/boto/boto3) from 1.17.32 to 1.17.33. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.32...1.17.33) Signed-off-by: dependabot[bot] <[email protected]> * Wildcard added to chemsys search * InsertionElectrode object added to model * API pinned to temp monty fix * Linting * github testing updated from master to main * Mypy fixes * Ignore missing imports mypy * Literal pulled from typing_extensions * More linting * added more fields to electrode doc (#229) * added more fields to electrode doc * added elements field * linting * update * more useful fields * Wildcard chemsys query bug fix * Linting * nelements added to general min max filter * Add minimal electrodes rester * ElementsQuery split from FormulaQuery * Element query added to electrodes endpoint * Linting * More linting * Elec dev (#230) * added more fields to electrode doc * added elements field * linting * update * more useful fields * small fixes * Elec dev (#231) * added more fields to electrode doc * added elements field * linting * update * more useful fields * small fixes * added nelements and formula_anonymous * update * Formula query added to electrodes endpoint * Docstring edit * Elec dev (#232) * added more fields to electrode doc * added elements field * linting * update * more useful fields * small fixes * added nelements and formula_anonymous * update * Working electrode API and client * Linting * Composition model swapped from pmg to pydantic Co-authored-by: Matthew Horton <[email protected]> Co-authored-by: Patrick Huck <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JSX <[email protected]>
tschaume
pushed a commit
that referenced
this pull request
Mar 26, 2021
* added more fields to electrode doc * added elements field * linting * update * more useful fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the fields so that the document is in line with electrode document from this emmet PR
materialsproject/emmet#178