Update client.py #418
Merged
Update client.py #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For materials with no valid charge density task_id like `mp-1104953` the current version gets an empty list at line 756 then errors out at the sorting step. This change should fix that. Also, I think it makes sense to return `None` here since we are not guaranteeing every single charge density.
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 92.61% 92.56% -0.05%
==========================================
Files 63 63
Lines 2031 2032 +1
==========================================
Hits 1881 1881
- Misses 150 151 +1
Continue to review full report at Codecov.
|
jmmshn
commented
Oct 27, 2021
| @@ -755,11 +761,16 @@ def get_charge_density_from_material_id(self, material_id: str) -> Optional[Chgc | |||
| ) | |||
| results = self.charge_density.search(task_ids=task_ids) | |||
There was a problem hiding this comment.
This can return empty sometimes
jmmshn
force-pushed
the
missing_chg_patch
branch
from
d8598f1 to
bb24955
Compare
|
Thanks @jmmshn ! |
|
Thanks! Sorry missed the review request until now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For materials with no valid charge density task_id like
mp-1104953the current version gets an empty list at line 756 then errors out at the sorting step.This change should fix that. Also, I think it makes sense to return
Nonehere since we are not guaranteeing every single charge density.