Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band structure, DOS, and charge density changes #577

Merged
merged 14 commits into from
Apr 20, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 20, 2022

This PR updates the client so it can properly receive msgpacked and compressed byte data for band structures and density of states. Additionally, charge density downloads are now handled through S3 urls client side.

@munrojm munrojm added the release:minor Minor release bump label Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #577 (d0ec494) into main (b877ae9) will decrease coverage by 0.14%.
The diff coverage is 85.29%.

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   92.45%   92.31%   -0.15%     
==========================================
  Files          34       34              
  Lines        1326     1353      +27     
==========================================
+ Hits         1226     1249      +23     
- Misses        100      104       +4     
Impacted Files Coverage Δ
src/mp_api/core/settings.py 100.00% <ø> (ø)
src/mp_api/routes/bonds.py 95.83% <ø> (ø)
src/mp_api/routes/dielectric.py 95.45% <ø> (ø)
src/mp_api/routes/elasticity.py 96.66% <ø> (ø)
src/mp_api/routes/electrodes.py 96.42% <ø> (ø)
src/mp_api/routes/eos.py 94.44% <ø> (ø)
src/mp_api/routes/grain_boundary.py 97.05% <ø> (ø)
src/mp_api/routes/magnetism.py 96.29% <ø> (ø)
src/mp_api/routes/materials.py 74.57% <0.00%> (ø)
src/mp_api/routes/molecules.py 93.10% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e96481...d0ec494. Read the comment docs.

@munrojm munrojm merged commit 047d832 into main Apr 20, 2022
@munrojm munrojm deleted the enhancement/api_s3_changes branch April 26, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants