-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dependencies #666
Conversation
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 87.10% 85.73% -1.38%
==========================================
Files 37 37
Lines 1559 1619 +60
==========================================
+ Hits 1358 1388 +30
- Misses 201 231 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mkhorton and @tschaume, I have added these warnings on instantiation should
I also raise an Furthermore, I have added a custom Want to make sure we are on the same page before I merge anything. Let me know if you have any thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@munrojm looks good overall. Left a few minor comments for your consideration.
@mkhorton, I am going to merge this unless you have an issue with anything. |
custodian
,mpcontribs-client
,boto3
, andemmet-core[all]
made optional dependenciesAlloyRester
import altered with warning to handle whenpymatgen-analysis-alloys
is not installed viaemmet-core