Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow strings for has_props #930

Merged
merged 2 commits into from
Aug 19, 2024
Merged

allow strings for has_props #930

merged 2 commits into from
Aug 19, 2024

Conversation

tschaume
Copy link
Member

@tschaume tschaume added the release:minor Minor release bump label Aug 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (8197ba3) to head (18eff30).

Files Patch % Lines
mp_api/client/routes/materials/summary.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   67.38%   67.37%   -0.01%     
==========================================
  Files          49       49              
  Lines        2520     2526       +6     
==========================================
+ Hits         1698     1702       +4     
- Misses        822      824       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tschaume tschaume merged commit 56bf699 into main Aug 19, 2024
4 checks passed
@tschaume tschaume deleted the has-props-strings branch August 19, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants