Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minting a new Atomate2 version #467

Closed
Andrew-S-Rosen opened this issue Aug 9, 2023 · 10 comments
Closed

Minting a new Atomate2 version #467

Andrew-S-Rosen opened this issue Aug 9, 2023 · 10 comments

Comments

@Andrew-S-Rosen
Copy link
Member

This issue is meant to track tasks that need to be completed for the next atomate2 version to be released. This will obviously depend a lot on @utf's comments, but here are some that I'm aware of:

@JaGeo
Copy link
Member

JaGeo commented Aug 9, 2023

I would be happy if the fixes to the phonons workflow would get included. They would both fix issues/bugs (#276 and #398).

@Andrew-S-Rosen
Copy link
Member Author

Andrew-S-Rosen commented Aug 9, 2023

Thanks! There were discussions at the last atomate2 meeting about adding more maintainers, so we can make sure these things get taken care of too since they seem to be in a merge-able state.

@JaGeo
Copy link
Member

JaGeo commented Aug 9, 2023

This sounds great. Happy to hear about such plans since we plan to contribute more work in the future as well.

@utf
Copy link
Member

utf commented Aug 14, 2023

Agreed we should focus on getting a new version out. I can use GitHub to generate release notes, the current release notes are pasted below. Some help tidying them later would be helpful.

In terms of PRs to merge before releasing a new version. Definitely:

And potentially:

What's Changed

New Contributors

Full Changelog: v0.0.10...v0.0.11

@janosh
Copy link
Member

janosh commented Aug 14, 2023

I'd exclude dependabot from release notes.

# .github/release.yml
changelog:
  exclude:
    authors: [dependabot[bot]]

@computron
Copy link
Member

Do release notes take time to prepare? If so, do we really need them?

@janosh
Copy link
Member

janosh commented Aug 21, 2023

@computron GitHub auto-generates these for you. Really nice feature.

@JaGeo
Copy link
Member

JaGeo commented Aug 22, 2023

General note: release notes are very helpful to showcase contributions to code before a publication in a journal. Luckily, this github feature exists

@utf
Copy link
Member

utf commented Sep 1, 2023

Thanks for the tip about .github/release.yml @janosh. I've added some more stuff in there, and now the automatically generated release notes use the tags to create sections. The current release notes look like this:

What's Changed

New Features 🎉

Bug Fixes 🐛

Enhancements 🛠

Documentation 📖

House-Keeping 🧹

New Contributors

Full Changelog: v0.0.10...v0.0.11

@utf
Copy link
Member

utf commented Sep 2, 2023

I've released a new version. We can also push a new one once the MP workflows are added.

@utf utf closed this as completed Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants