Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CondensedBondingAnalysis schema #469

Merged

Conversation

naik-aakash
Copy link
Contributor

Adapts argument names as per latest LobsterPy release which breaks the Lobster workflow schema

Closes #468

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #469 (ffab0cc) into main (95b15d5) will decrease coverage by 0.16%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   65.30%   65.15%   -0.16%     
==========================================
  Files          74       74              
  Lines        7186     7186              
  Branches      927      927              
==========================================
- Hits         4693     4682      -11     
- Misses       2208     2220      +12     
+ Partials      285      284       -1     
Files Changed Coverage Δ
src/atomate2/lobster/schemas.py 92.74% <100.00%> (ø)

... and 1 file with indirect coverage changes

@naik-aakash naik-aakash changed the title [WIP] Update CondensedBondingAnalysis schema Update CondensedBondingAnalysis schema Aug 13, 2023
@naik-aakash
Copy link
Contributor Author

naik-aakash commented Aug 13, 2023

Hi @utf , this PR is ready to be reviewed and merged.

It has minor changes just to adapt to the latest release of lobsterpy

@JaGeo
Copy link
Member

JaGeo commented Aug 13, 2023

@naik-aakash , could you change the requirements in the lobster part as well? >=0.3.0?

@naik-aakash
Copy link
Contributor Author

@naik-aakash , could you change the requirements in the lobster part as well? >=0.3.0?

Done 😃

@utf
Copy link
Member

utf commented Aug 14, 2023

Great, thanks!

@utf utf merged commit ae165ef into materialsproject:main Aug 14, 2023
@utf utf added the enhancement Improvements to existing features label Sep 1, 2023
@naik-aakash naik-aakash deleted the lobster_schema_new_lobsterpy_release branch June 20, 2024 06:59
@naik-aakash naik-aakash restored the lobster_schema_new_lobsterpy_release branch June 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New LobsterPy release
3 participants