-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CondensedBondingAnalysis schema #469
Update CondensedBondingAnalysis schema #469
Conversation
Adapts argument names as per latest LobsterPy release which breaks the Lobster workflow schema
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 65.30% 65.15% -0.16%
==========================================
Files 74 74
Lines 7186 7186
Branches 927 927
==========================================
- Hits 4693 4682 -11
- Misses 2208 2220 +12
+ Partials 285 284 -1
|
Hi @utf , this PR is ready to be reviewed and merged. It has minor changes just to adapt to the latest release of lobsterpy |
@naik-aakash , could you change the requirements in the lobster part as well? >=0.3.0? |
Done 😃 |
Great, thanks! |
Adapts argument names as per latest LobsterPy release which breaks the Lobster workflow schema
Closes #468