Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow energy minimization maker to report energies #1004

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

orionarcher
Copy link
Contributor

Previously the energy minimization maker didn't have any way of reporting energies. This fixes that.

Implemented:

  • allow energy minimization maker to report energy
  • test energy reporting

@orionarcher
Copy link
Contributor Author

Tagging @janosh for review

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@janosh janosh added enhancement Improvements to existing features md Molecular dynamics labels Oct 1, 2024
@janosh janosh merged commit fb9a6e8 into materialsproject:main Oct 1, 2024
15 checks passed
hrushikesh-s pushed a commit to hrushikesh-s/atomate2 that referenced this pull request Nov 16, 2024
…1004)

* Make energy minimization reporter report a state file when it runs. This allows us to see energies of minimized configuration.

* Only report energy minimization state if state_interval > 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features md Molecular dynamics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants