-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing tutorial for high level overview of atomate2 concepts. #757
Conversation
Drafting the tutorial text.
For now, I have simply drafted a markdown file. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 74.94% 76.91% +1.96%
==========================================
Files 136 122 -14
Lines 10513 9108 -1405
Branches 1643 1429 -214
==========================================
- Hits 7879 7005 -874
+ Misses 2143 1675 -468
+ Partials 491 428 -63 |
Hey Alex @utf |
Hi @QuantumChemist, thanks for making a start on this. If possible, I would aim to make the tutorial more pedagogical with more emphasis on what the concepts are for rather than delving too much into the code specifics. In general, I imagine that this tutorial will be the first time users are exposed to these concepts, so the main aim is for users to understand why they need to work with these objects and what they achieve, rather than how exactly they work (although this could be included later on in the tutorial). For example, it could be helpful to have a high level overview at the beginning of the document summarising verbally or graphically how these components interact and form a workflow. You can then give delve into each topic. I would start by giving examples from the atomate2 code and state what is happening in each case. And then if necessary you can give detailed insights into the jobflow source. Although I think this should be minimised as much as possible. In terms of the writing style and level of detail, I would use the documentation of QuAcc as an example. |
Ok, thank you so much for the feedback! :) |
Hi @utf , I have now adjusted the tutorial text and tried to make it more pedagogical. And I'm very sorry, I was misunderstanding the "high-level overview" part a little bit, and upon looking up the definition, it became clearer to me how the tutorial is supposed to be. I also included a (draft) figure for checking out how that would look like in the tutorial and kept some technical details, as having those helped me a lot in the beginning when I started to work with atomate2. If the current style is ok like that, then I would go on and write the other sections in a similar way and also make proper figures (the one figure is there for demonstration and drafting purposes). If this is not ok, I'd be very happy about more feedback on my text! |
Hi @QuantumChemist, this looks perfect. Thank you. |
Great! Then I will continue the rest of the tutorial like that! Thx! |
Noting some idea
Hey @utf :) |
merging MP/main with my main
Auto-update pre-commit hooks
This is fantastic. Thank you @QuantumChemist and @JaGeo. |
@utf Thank you as well! 😃 |
…ialsproject#757) * Create high_level_overview.md Drafting the tutorial text. * added Job and Flow makers section to the tutorial * added Job and Flow makers section to the tutorial * changed the style of the tutorial * structure the text better * Added todo Noting some idea * added the section for InputSet and Builder * adding job maker @job decorator explanation * Update key_concepts_overview.md * removing unnecessary line * remove unnecessary lines * added section for taskdocs * fixing typo * fixing typo * Noting some idea * revised the tutorial, fixed tpos etc. * minor changes * minor changes * Auto-update pre-commit hooks * Update docs/user/key_concepts_overview.md Co-authored-by: J. George <[email protected]> --------- Co-authored-by: QuantumChemist <[email protected]> Co-authored-by: J. George <[email protected]>
Hey @utf , So I wonder: Shall I fix this in another PR? If yes, shall I link it to the User Guide, also in a way that it shows up on the User Guide sidebar on the left or shall I link it to the welcome page? What do you think would be best? |
…ialsproject#757) * Create high_level_overview.md Drafting the tutorial text. * added Job and Flow makers section to the tutorial * added Job and Flow makers section to the tutorial * changed the style of the tutorial * structure the text better * Added todo Noting some idea * added the section for InputSet and Builder * adding job maker @job decorator explanation * Update key_concepts_overview.md * removing unnecessary line * remove unnecessary lines * added section for taskdocs * fixing typo * fixing typo * Noting some idea * revised the tutorial, fixed tpos etc. * minor changes * minor changes * Auto-update pre-commit hooks * Update docs/user/key_concepts_overview.md Co-authored-by: J. George <[email protected]> --------- Co-authored-by: QuantumChemist <[email protected]> Co-authored-by: J. George <[email protected]>
Summary
This PR will add a tutorial for atomate2, giving a detailed overview of its key concepts.
TODO Checklist
The following sections have to be added