Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEP MLIP relax, static, and MD makers #893

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Jun 22, 2024

Summary: Added NEP MLIP relax, static, and MD maker

I have added makers so NEP potentials can also be used in atomate2 workflows.
A general-purpose NEP potential for 16 elemental metals and their alloys was made available last year.

Implemented Makers at this point use the ase-calculator implemented in the calorine package

Todos:

  • Add tests

@naik-aakash naik-aakash marked this pull request as draft June 22, 2024 09:51
@naik-aakash naik-aakash changed the title [WIP] add NEP MLIP relax. static and MD makers [WIP] added NEP MLIP relax, static, and MD makers Jun 22, 2024
@naik-aakash naik-aakash marked this pull request as ready for review June 26, 2024 11:08
@naik-aakash naik-aakash changed the title [WIP] added NEP MLIP relax, static, and MD makers Added NEP MLIP relax, static, and MD makers Jun 26, 2024
@naik-aakash
Copy link
Contributor Author

Hi @utf , this PR is ready for review and could be merged .

@utf
Copy link
Member

utf commented Jul 18, 2024

Looks great, thanks @naik-aakash.

@utf utf merged commit 1118986 into materialsproject:main Jul 18, 2024
6 checks passed
@utf utf added the enhancement Improvements to existing features label Jul 18, 2024
@utf utf changed the title Added NEP MLIP relax, static, and MD makers Add NEP MLIP relax, static, and MD makers Jul 18, 2024
BryantLi-BLI pushed a commit to BryantLi-BLI/atomate2 that referenced this pull request Jul 29, 2024
* add NEP FF relax. static and MD makers

* add tests for NEP relax, static and md makers

* add model license and source

* Update tests/forcefields/test_jobs.py

Co-authored-by: Christina Ertural <[email protected]>

---------

Co-authored-by: Christina Ertural <[email protected]>
hrushikesh-s pushed a commit to hrushikesh-s/atomate2 that referenced this pull request Nov 16, 2024
* add NEP FF relax. static and MD makers

* add tests for NEP relax, static and md makers

* add model license and source

* Update tests/forcefields/test_jobs.py

Co-authored-by: Christina Ertural <[email protected]>

---------

Co-authored-by: Christina Ertural <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants