Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #290

Merged
merged 8 commits into from
Sep 10, 2023
Merged

Fix lint errors #290

merged 8 commits into from
Sep 10, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Sep 10, 2023

57f5ca9 bump pre-commit black version
face368 fix PT027: use pytest.raises instead of unittest-style assertRaises

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 34.32% and project coverage change: -0.10% ⚠️

Comparison is base (e133fe0) 66.20% compared to head (9ade654) 66.11%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   66.20%   66.11%   -0.10%     
==========================================
  Files          51       51              
  Lines        5590     5610      +20     
==========================================
+ Hits         3701     3709       +8     
- Misses       1889     1901      +12     
Files Changed Coverage Δ
custodian/cli/run_vasp.py 0.00% <0.00%> (ø)
...todian/qchem/tests/test_job_handler_interaction.py 37.87% <0.00%> (ø)
custodian/vasp/jobs.py 49.72% <0.00%> (ø)
custodian/qchem/tests/test_jobs.py 23.91% <6.81%> (-0.54%) ⬇️
custodian/ansible/tests/test_interpreter.py 100.00% <100.00%> (ø)
custodian/tests/test_custodian.py 98.90% <100.00%> (+0.04%) ⬆️
custodian/vasp/tests/test_handlers.py 99.78% <100.00%> (ø)
custodian/vasp/tests/test_jobs.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit 85cf4aa into master Sep 10, 2023
@janosh janosh deleted the fix-lint branch September 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants