Ensure run, calc, and task types are always refreshed in TaskDoc #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple changes to
TaskDocstructure: during post init, therun_type,task_typeandcalc_type(union of the previous two) are always updated to ensure that these are consistent with subsequent bug fixes. Previously, these were only updated iftask_typewasNone.This change is motivated by #960, where the
run_typewas incorrectly determined for any non-GGA run and some discussions with @mkhorton. By re-initializing aTaskDocfrom a dict, these changes would correctly populate the three fields.The source of the bug in 960 is separately fixed in #1026. This change would also ensure that 1026 also patches fields in legacy TaskDocs