Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks for TaskDoc's model_post_init #1074

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tschaume
Copy link
Member

@tsmathis @esoteric-ephemera fix for these two forum threads:

When the task model is initiated from a database document, the document might not contain the necessary fields depending on what the user requested.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.00%. Comparing base (f3d65de) to head (47cefe5).
Report is 2 commits behind head on main.

Files Patch % Lines
emmet-core/emmet/core/tasks.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   90.00%   90.00%   -0.01%     
==========================================
  Files         143      143              
  Lines       13432    13438       +6     
==========================================
+ Hits        12090    12095       +5     
- Misses       1342     1343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tschaume tschaume merged commit d748a2d into main Aug 19, 2024
7 checks passed
@tschaume tschaume deleted the add-checks-for-tasks-model_post_init branch August 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants