Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force dynamic enum generation for emmet-core #1097

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

tsmathis
Copy link
Collaborator

adding the explicit call to importlib forces the full module import, and triggers the corresponding exception to autogenerate the enums.

the static import statement can cause importlib's bootstrapping to fail in environments that only partially initialize the module at startup

@tsmathis tsmathis added the Core Any updates for Emmet-Core label Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (1d490e0) to head (157bfd0).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1097       +/-   ##
===========================================
+ Coverage   72.66%   90.28%   +17.61%     
===========================================
  Files          77      147       +70     
  Lines        5015    14157     +9142     
===========================================
+ Hits         3644    12781     +9137     
- Misses       1371     1376        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit c3c62e7 into main Sep 12, 2024
7 checks passed
@tsmathis tsmathis deleted the force-dynamic-enum-generation branch September 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants