Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update elasticity builder asserts #1117

Merged
merged 1 commit into from
Sep 27, 2024
Merged

update elasticity builder asserts #1117

merged 1 commit into from
Sep 27, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Sep 27, 2024

Following changes in #767 the elasticity builder tests were breaking. Discussion around the changes led to the conclusion that the newly failing docs should in fact be failing.

Follow up checking of the fully built elasticity data using the updated code will need to be done.

The test files for the builder should then be updated at that point to reflect the new expectations of the builder output

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (88c6a94) to head (246d8a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   88.84%   90.00%   +1.16%     
==========================================
  Files         114      143      +29     
  Lines       10629    13714    +3085     
==========================================
+ Hits         9443    12343    +2900     
- Misses       1186     1371     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis added Builders Any updates for Emmet-Builders ci Continuous integration labels Sep 27, 2024
@tsmathis tsmathis merged commit beeedab into main Sep 27, 2024
8 checks passed
@tsmathis tsmathis deleted the update-elasticity-tests branch September 27, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders Any updates for Emmet-Builders ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants