Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for electrode builder #113

Merged
merged 24 commits into from
Mar 25, 2020
Merged

fixes for electrode builder #113

merged 24 commits into from
Mar 25, 2020

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Jan 10, 2020

  • Added a test file with Bi-Li-O system
  • Added tests for main functions in the electrode builder and most of the auxiliary functions
  • updated and cleaned up the code for the electrode builder: considerations for non-symmetric and non-commutative structure matcher equalities.

@jmmshn
Copy link
Contributor Author

jmmshn commented Jan 15, 2020

It looks like the pytest system is failing during setup.

@shyamd shyamd merged commit 7bcbeac into materialsproject:updates Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmmshn @shyamd