Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize settings #173

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions emmet-builders/emmet/builders/vasp/materials.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def __init__(
materials: Store,
task_validation: Optional[Store] = None,
query: Optional[Dict] = None,
settings: Optional[EmmetBuildSettings] = None,
user_settings: Optional[EmmetBuildSettings] = None,
**kwargs,
):
"""
Expand All @@ -62,7 +62,8 @@ def __init__(
self.materials = materials
self.task_validation = task_validation
self.query = query if query else {}
self.settings = settings or SETTINGS
self.user_settings = user_settings
self.settings = user_settings or SETTINGS
self.kwargs = kwargs

sources = [tasks]
Expand Down
5 changes: 3 additions & 2 deletions emmet-builders/emmet/builders/vasp/task_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __init__(
self,
tasks: Store,
task_validation: Store,
settings: Optional[EmmetBuildSettings] = None,
user_settings: Optional[EmmetBuildSettings] = None,
**kwargs,
):
"""
Expand All @@ -32,7 +32,8 @@ def __init__(
"""
self.tasks = tasks
self.task_validation = task_validation
self.settings = settings or SETTINGS
self.user_settings = user_settings
self.settings = user_settings or SETTINGS
self.kwargs = kwargs

super().__init__(
Expand Down