Updated materials and thermo builder #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmmshn
commented
Mar 16, 2021
jmmshn
commented
- materials_id now uses the smallest possible value to prevent drift
- fixed typo in thermo builder now works, results on 'mp_core_new'
- changed some install settings to allow more flexibility in the requirements.txt
- pegged to pymatgen version to the master branch
updated error message update
jmmshn
changed the title
shyamd
reviewed
Mar 22, 2021
| @@ -54,6 +54,12 @@ def from_tasks( | |||
| quality_scores: quality scores for various calculation types | |||
| use_statics: Use statics to define a material | |||
| """ | |||
| if task_group == 0: | |||
There was a problem hiding this comment.
Should there be len in there?
There was a problem hiding this comment.
Yeah I'll add a test for and update this PR
shyamd
reviewed
Mar 22, 2021
utf
pushed a commit
to utf/emmet
that referenced
this pull request
May 8, 2021
…bot/pip/boto3-1.13.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.