Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electronic Structure model and builder fixes #206

Merged
merged 5 commits into from
Jun 21, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jun 16, 2021

This PR contains:

  • Electronic structure now properly populates magnetic ordering from each task's output structure
  • Type hinting for MPIDs fixed in electronic structure model

@munrojm munrojm added the release:patch Patch updates label Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #206 (ec08158) into main (ae3c8c8) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   89.53%   89.43%   -0.10%     
==========================================
  Files          36       36              
  Lines        2484     2490       +6     
==========================================
+ Hits         2224     2227       +3     
- Misses        260      263       +3     
Impacted Files Coverage Δ
emmet-core/emmet/core/xas.py 33.64% <ø> (ø)
...s/emmet/builders/materials/electronic_structure.py 64.70% <60.00%> (-0.54%) ⬇️
emmet-core/emmet/core/electrode.py 97.56% <100.00%> (ø)
emmet-core/emmet/core/electronic_structure.py 89.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c636258...ec08158. Read the comment docs.

@munrojm munrojm changed the title [WIP] Electronic Structure model and builder fixes Electronic Structure model and builder fixes Jun 17, 2021
@munrojm munrojm merged commit d8e6010 into materialsproject:main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants