Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deprecated tasks in Materials Builder #207

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Use deprecated tasks in Materials Builder #207

merged 2 commits into from
Jun 21, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 21, 2021

Deprecated tasks were being filtered out too early causing them to disappear. This should remedy that.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #207 (e2155a6) into main (ae3c8c8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          36       36           
  Lines        2484     2484           
=======================================
  Hits         2224     2224           
  Misses        260      260           
Impacted Files Coverage Δ
emmet-core/emmet/core/vasp/material.py 98.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c636258...e2155a6. Read the comment docs.

@shyamd shyamd added the release:patch Patch updates label Jun 21, 2021
@shyamd shyamd merged commit 87135f5 into main Jun 21, 2021
@munrojm munrojm deleted the shyamd-deprecated branch May 11, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants