Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecated Materials to MaterialsDoc construction #220

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jul 12, 2021

This adds a default way to construct a deprecated materials doc and uses that in the builder so we can keep track of all task_ids .

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #220 (6aee820) into main (517fc8d) will decrease coverage by 11.59%.
The diff coverage is 10.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #220       +/-   ##
===========================================
- Coverage   85.97%   74.37%   -11.60%     
===========================================
  Files          37       34        -3     
  Lines        1818     1600      -218     
===========================================
- Hits         1563     1190      -373     
- Misses        255      410      +155     
Impacted Files Coverage Δ
emmet-builders/emmet/builders/vasp/materials.py 82.90% <0.00%> (-0.72%) ⬇️
emmet-core/emmet/core/vasp/material.py 77.63% <11.11%> (-20.65%) ⬇️
emmet-core/emmet/core/electronic_structure.py 39.06% <0.00%> (-50.00%) ⬇️
emmet-core/emmet/core/thermo.py 52.00% <0.00%> (-38.00%) ⬇️
emmet-core/emmet/core/provenance.py 58.20% <0.00%> (-37.32%) ⬇️
emmet-core/emmet/core/mpid.py 62.00% <0.00%> (-32.00%) ⬇️
emmet-core/emmet/core/structure.py 86.48% <0.00%> (-13.52%) ⬇️
emmet-core/emmet/core/settings.py 89.58% <0.00%> (-8.34%) ⬇️
emmet-core/emmet/core/vasp/validation.py 78.57% <0.00%> (-7.15%) ⬇️
emmet-core/emmet/core/utils.py 85.07% <0.00%> (-5.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517fc8d...6aee820. Read the comment docs.

@shyamd shyamd merged commit 8a629ff into main Jul 12, 2021
@shyamd shyamd deleted the fix-builders branch July 12, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants