Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provenance overhaul #255

Merged
merged 9 commits into from
Sep 2, 2021
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 2, 2021

This PR overhauls ProvenanceBuilder to fix slowness issues.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #255 (6ec6b01) into main (380cfc3) will decrease coverage by 5.09%.
The diff coverage is 77.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   91.72%   86.63%   -5.10%     
==========================================
  Files          43       35       -8     
  Lines        2865     2507     -358     
==========================================
- Hits         2628     2172     -456     
- Misses        237      335      +98     
Impacted Files Coverage Δ
emmet-core/emmet/core/thermo.py 52.00% <0.00%> (-38.00%) ⬇️
emmet-core/emmet/core/provenance.py 59.09% <22.22%> (-34.96%) ⬇️
emmet-core/emmet/core/xas.py 33.64% <22.22%> (ø)
...s/emmet/builders/materials/electronic_structure.py 85.84% <80.00%> (ø)
emmet-core/emmet/core/electronic_structure.py 86.39% <100.00%> (-8.85%) ⬇️
emmet-core/emmet/core/material.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/material_property.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/oxidation_states.py 93.02% <100.00%> (+0.16%) ⬆️
emmet-core/emmet/core/structure.py 86.48% <100.00%> (-13.52%) ⬇️
emmet-core/emmet/core/summary.py 88.18% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661c0b3...6ec6b01. Read the comment docs.

@munrojm munrojm merged commit ce8a71c into materialsproject:main Sep 2, 2021
@munrojm munrojm deleted the provenance_bug_fixes branch September 2, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants