Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder chunking fixes #287

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Builder chunking fixes #287

merged 3 commits into from
Oct 21, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 21, 2021

This PR fixes chunking on remaining non-map builders. is_magnetic fix is also added to summary builder.

@munrojm munrojm added the release:patch Patch updates label Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #287 (5f8ace2) into main (13b8746) will decrease coverage by 0.34%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   89.48%   89.13%   -0.35%     
==========================================
  Files          45       45              
  Lines        2367     2383      +16     
==========================================
+ Hits         2118     2124       +6     
- Misses        249      259      +10     
Impacted Files Coverage Δ
...et-builders/emmet/builders/materials/dielectric.py 88.00% <50.00%> (-6.03%) ⬇️
...builders/emmet/builders/materials/piezoelectric.py 88.15% <54.54%> (-5.96%) ⬇️
emmet-core/emmet/core/summary.py 88.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25570c5...5f8ace2. Read the comment docs.

@munrojm munrojm merged commit 2b86ed2 into main Oct 21, 2021
@munrojm munrojm deleted the builder_chunking_fixes branch October 21, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants