Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electrode chunking #288

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fix electrode chunking #288

merged 1 commit into from
Oct 25, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 25, 2021

No description provided.

@munrojm munrojm added the release:patch Patch updates label Oct 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #288 (1fb3b82) into main (2b86ed2) will increase coverage by 0.04%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   89.13%   89.18%   +0.04%     
==========================================
  Files          45       47       +2     
  Lines        2383     2477      +94     
==========================================
+ Hits         2124     2209      +85     
- Misses        259      268       +9     
Impacted Files Coverage Δ
emmet-core/emmet/core/summary.py 88.39% <ø> (ø)
emmet-core/emmet/core/oxidation_states.py 91.11% <50.00%> (-2.08%) ⬇️
...met-builders/emmet/builders/materials/magnetism.py 87.69% <87.69%> (ø)
...et-builders/emmet/builders/materials/dielectric.py 88.00% <100.00%> (ø)
...lders/emmet/builders/materials/oxidation_states.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/magnetism.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4d53d...1fb3b82. Read the comment docs.

@munrojm munrojm merged commit 1045367 into main Oct 25, 2021
@munrojm munrojm deleted the electrodes_fix branch October 25, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants